Fix display and use of statistical depth surfaces #13421
+18
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly invoke RimSurfaceCollection::addSurface when adding statistic surfaces in RimEnsembleSurface's constructor. This clarifies method resolution and ensures the correct base class implementation is used.
magnesj
force-pushed
the
improve-ensemble-surface-import
branch
from
af52d64 to
70d7386
Compare
magnesj
force-pushed
the
improve-ensemble-surface-import
branch
from
70d7386 to
6b3fa4d
Compare
Ensures that the depth property is correctly set for regular file surfaces after loading data. This allows the property to be utilized as a depth value.
magnesj
force-pushed
the
improve-ensemble-surface-import
branch
from
6b3fa4d to
0eb980e
Compare
kriben
requested changes
Jan 16, 2026
Comment on lines
-71
to
74
| with pytest.raises(rips.RipsError, match="Failed to set depth property."): | ||
| s.set_property_as_depth(name="non_existing_property") | ||
|
|
||
| with pytest.raises( |
Collaborator
There was a problem hiding this comment.
Is there a way to keep this check? Setting it to a non-existing value is a programmer error, and it would be nice for the "scripter" to get a message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the organization of ensemble surfaces in the project tree.
Closes #13338
Related to #13331