M_IOBUF size definable from the constructor (backward compatible)#108
Open
mcmchris wants to merge 3 commits intoOPEnSLab-OSU:masterfrom
Open
M_IOBUF size definable from the constructor (backward compatible)#108mcmchris wants to merge 3 commits intoOPEnSLab-OSU:masterfrom
mcmchris wants to merge 3 commits intoOPEnSLab-OSU:masterfrom
Conversation
Added the support to define the m_iobuf size in the constructor.
Changed m_iobuf from a fixed-size array to a pointer and added m_iobuf_size for dynamic memory management.
Added buffer_size parameter to SSLClient constructor for improved flexibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added the non disruptive support to change m_iobuf from a fixed-size array to a pointer and add m_iobuf_size for dynamic memory management.
Fixes # (issue)
Type of change
Please uncheck options that are not relevant.
How Has This Been Tested?
I tested this code by using a custom PCB that features the W5500 and it is using Ethernet to download OTA firmware updates from Github. With the original 2048 fixed buffer the download was very slow and cut in small chunks, with the dynamic buffer, I went from 2:30 minutes download to 10 seconds. Also, I tested backward compatibility.
Test Configuration: