[16.0][IMP] Make base_external_system easily extendable#414
[16.0][IMP] Make base_external_system easily extendable#414
Conversation
NL66278
force-pushed
the
16.0-base_external_system-extendable
branch
2 times, most recently
from
4790a4f to
daa8398
Compare
| ) | ||
| % { | ||
| "exception": exc, | ||
| "system_name": self.name, |
There was a problem hiding this comment.
Personally I always find it slightly annoying if exceptions are converted to something else than they previously were. At the very least can we log the traceback, either in the logfile or to the chatter if it exists? Then it is possible to know where things went wrong.
There was a problem hiding this comment.
Basically this is feedback to the user that he/she probably made an error configuring the connection. The action is to test the connection. So I think a ValidationError is the right thing to do here.
NL66278
force-pushed
the
16.0-base_external_system-extendable
branch
5 times, most recently
from
5d9e8da to
d9aecbe
Compare
|
@thomaspaulb I took up your comments, please look again |
NL66278
force-pushed
the
16.0-base_external_system-extendable
branch
from
d9aecbe to
e8222e9
Compare
| Changelog | ||
| ========= | ||
|
|
||
| Version 16.0.1.0.0 |
There was a problem hiding this comment.
Given all the major breaking changes done here, should they also be explained with a 16.0.2.0.0 changelog comment, with a rationale and a migration path? If someone had made custom dependent modules that add fields on base.external.system, this will now stop working and someone will need to redo the customization in a new way.
There was a problem hiding this comment.
Ok sorry I'm talking nonsense here, it's not base.external.system that went to become an AbstractModel. Still, I would appreciate an explanation why this is better, if only to be able to review better, and for users to understand.
NL66278
force-pushed
the
16.0-base_external_system-extendable
branch
2 times, most recently
from
ceae1a5 to
bad61bb
Compare
This module will be extended with modules to connect to http systems, with additional modules to use oauth authorization.
NL66278
force-pushed
the
16.0-base_external_system-extendable
branch
from
bad61bb to
1b0b97b
Compare
3 participants
This module will be extended with modules to connect to http systems, with additional modules to use oauth authorization.
This code is running in production at several customer sites already, together with additional modules for which PR's will follow.