[19.0][MIG] report_csv: Migration to 19.0#1131
Open
Conversation
…case you are in [UPD] Update report_csv.pot
[UPD] Update report_csv.pot [UPD] README.rst
[UPD] Update report_csv.pot [UPD] README.rst report_csv 13.0.1.0.1 pre-commit update
[UPD] Update report_csv.pot [UPD] README.rst
report_csv 16.0.1.0.1 [UPD] README.rst
[UPD] Update report_csv.pot [BOT] post-merge updates
Translated using Weblate (Italian) Currently translated at 100.0% (14 of 14 strings) Translation: reporting-engine-16.0/reporting-engine-16.0-report_csv Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-16-0/reporting-engine-16-0-report_csv/it/
Translated using Weblate (Spanish) Currently translated at 100.0% (14 of 14 strings) Translation: reporting-engine-16.0/reporting-engine-16.0-report_csv Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-16-0/reporting-engine-16-0-report_csv/es/
[BOT] post-merge updates
len() is used on docids, but in some cases, docids is None wich raised a TypeError
|
I have tested it and the code does work, but I left a small review point. |
Author
@ddejong-therp did you submit your review? there are no review comments. |
| return res | ||
| report_obj = self.env["ir.actions.report"] | ||
| qwebtypes = ["csv"] | ||
| conditions = [ |
There was a problem hiding this comment.
You can use the new domain class here.
See https://www.odoo.com/documentation/19.0/developer/reference/backend/orm.html?highlight=orm#reference-orm-domains
It looks like I did not submit the review indeed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
standard migration,
few changes done: