[17.0][ADD] product_margin_report_landed_costs#247
[17.0][ADD] product_margin_report_landed_costs#247edescalona wants to merge 1 commit intoOCA:17.0from
Conversation
edescalona
force-pushed
the
17.0-add-product_margin_report_landed_costs
branch
4 times, most recently
from
fd3dd39 to
0c197cc
Compare
rrebollo
left a comment
rrebollo
left a comment
There was a problem hiding this comment.
Pure Code Review. LGTM!!! I do think functional review is critical on this kind of addons. Great contribution.
product_margin_report_landed_costs/tests/test_product_margin_report_landed_costs.py
Outdated
Show resolved
Hide resolved
product_margin_report_landed_costs/tests/test_product_margin_report_landed_costs.py
Outdated
Show resolved
Hide resolved
product_margin_report_landed_costs/tests/test_product_margin_report_landed_costs.py
Show resolved
Hide resolved
|
I don't have extensive knowledge of stock valuation methodologies, but I am aware of the key differences between Anglo-Saxon and Continental accounting principles. Perhaps you could mention any prerequisites regarding those accounting standards in addon's documentation. |
…ated with the product to the Product Margins report.
edescalona
force-pushed
the
17.0-add-product_margin_report_landed_costs
branch
from
0c197cc to
6ed45cf
Compare
|
ping @rrebollo |
|
Nice job @edescalona |
|
ping @Christian-RB |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
2 participants
@BinhexTeam
Add the landed costs associated with the product to the Product Margins report.