Skip to content

[17.0][FW] geospatial: Multiple ports from 16.0#436

Open
anusriNPS wants to merge 3 commits intoOCA:17.0from
PyTech-SRL:17-port-from-16-enhance_geoengine
Open

[17.0][FW] geospatial: Multiple ports from 16.0#436
anusriNPS wants to merge 3 commits intoOCA:17.0from
PyTech-SRL:17-port-from-16-enhance_geoengine

Conversation

@anusriNPS
Copy link
Contributor

@anusriNPS anusriNPS commented Jan 28, 2026

Port from 16.0:
FW: #409 - [16.0][IMP] base_geoengine: Include edit button in Popup
FW: #400 - [16.0][IMP][base_geoengine]: Update Domain for attribute_field_id
FW: #377 - [16.0][FIX] base_geoengine: Updated field label

@anusriNPS anusriNPS marked this pull request as draft January 28, 2026 09:06
@anusriNPS anusriNPS force-pushed the 17-port-from-16-enhance_geoengine branch from d4f8814 to 0d201ff Compare January 28, 2026 09:29
@anusriNPS anusriNPS marked this pull request as ready for review January 28, 2026 09:35
Copy link

@quirino95 quirino95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yvaucher
Copy link
Member

Superseeds #430

@yvaucher
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

@yvaucher The merge process could not start, because command `git merge --no-ff -m 'Merge PR #436 into 17.0

Signed-off-by yvaucher' tmp-pr-436` failed with output:

Auto-merging geoengine_base_geolocalize/tests/test_geoengine_partner.py
CONFLICT (content): Merge conflict in geoengine_base_geolocalize/tests/test_geoengine_partner.py
Automatic merge failed; fix conflicts and then commit the result.

@yvaucher
Copy link
Member

You can remove the last commit, didn't see you fixed in here. I already pushed an alternative.

   Updated field label from "Params" to "Params WMS"
of params_wms
   attribute_field_id domain is updated to use values
based on geo_field_id.model_id
   Added edit button in popup of record shown in geoengine
view which allows user to edit values of record from
geoengine view.
@anusriNPS anusriNPS force-pushed the 17-port-from-16-enhance_geoengine branch from 0d201ff to 4fdc144 Compare February 25, 2026 14:36
@anusriNPS
Copy link
Contributor Author

You can remove the last commit, didn't see you fixed in here. I already pushed an alternative.

Thank you for the info.Removed the commit which was added to fix testcase issue @yvaucher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants