-
-
Notifications
You must be signed in to change notification settings - Fork 387
[14.0][FIX] sale_commission_product_criteria: Get items without commission #660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 14.0
Are you sure you want to change the base?
[14.0][FIX] sale_commission_product_criteria: Get items without commission #660
Conversation
Otherwise the following error happens:
ERROR: operator does not exist: integer = boolean
LINE 9: AND (item.commission_id = false)
^
HINT: No operator matches the given name and argument types. You might need to add explicit type casts
|
Hi @PicchiSeba, @renda-dev, @aleuffre, @ilyasProgrammer, |
Tisho99
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Code review. ¿Could you add the version to the PR title?
Thanks for the review! |
|
@SirPyTech We don't review things from older versions. Sorry for the inconvenience. Next time, please don't ping two people from the same company. Thanks. |
Thanks for the feedback anyway 🤗 |
No problem 😸 . You should ping the repository's psc's; they're the ones who maintain the whole ecosystem. |
I usually bother the PSC only when the PR has enough reviews. |
Backporting 2 small PRs from
16.0: #615 and #619.@Tisho99, @ValentinVinagre and @manuelregidor thanks for your work on those PRs!
Maybe you want to have a look?
I have also a dded a fix for method
_get_commission_items: unfortunately I don't know ho to reproduce it from the UI, but calling the method with an emptycommissionraises:See the added test for more details.