Skip to content

Conversation

@SirPyTech
Copy link

Backporting 2 small PRs from 16.0: #615 and #619.
@Tisho99, @ValentinVinagre and @manuelregidor thanks for your work on those PRs!
Maybe you want to have a look?


I have also a dded a fix for method _get_commission_items: unfortunately I don't know ho to reproduce it from the UI, but calling the method with an empty commission raises:

ERROR: operator does not exist: integer = boolean
LINE 9:             AND (item.commission_id = false)
                                            ^
HINT:  No operator matches the given name and argument types. You might need to add explicit type casts

See the added test for more details.

Tisho99 and others added 3 commits February 3, 2026 09:34
Otherwise the following error happens:
ERROR: operator does not exist: integer = boolean
LINE 9:             AND (item.commission_id = false)
                                            ^
HINT:  No operator matches the given name and argument types. You might need to add explicit type casts
@OCA-git-bot
Copy link
Contributor

Hi @PicchiSeba, @renda-dev, @aleuffre, @ilyasProgrammer,
some modules you are maintaining are being modified, check this out!

@SirPyTech SirPyTech marked this pull request as ready for review February 3, 2026 09:13
Copy link
Contributor

@Tisho99 Tisho99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Code review. ¿Could you add the version to the PR title?

@SirPyTech SirPyTech changed the title [FIX] sale_commission_product_criteria: Get items without commission [14.0][FIX] sale_commission_product_criteria: Get items without commission Feb 3, 2026
@SirPyTech
Copy link
Author

LGTM. Code review. ¿Could you add the version to the PR title?

Thanks for the review!
I usually don't add it because it feels redundant, but here I added it to thank you for the approval 😉

@ValentinVinagre
Copy link

@SirPyTech We don't review things from older versions. Sorry for the inconvenience. Next time, please don't ping two people from the same company. Thanks.

@SirPyTech
Copy link
Author

@SirPyTech We don't review things from older versions. Sorry for the inconvenience. Next time, please don't ping two people from the same company. Thanks.

Thanks for the feedback anyway 🤗
Sorry for the noise, as you know it's hard to get reviews in the OCA so I usually ping whoever might be interested.

@ValentinVinagre
Copy link

@SirPyTech We don't review things from older versions. Sorry for the inconvenience. Next time, please don't ping two people from the same company. Thanks.

Thanks for the feedback anyway 🤗 Sorry for the noise, as you know it's hard to get reviews in the OCA so I usually ping whoever might be interested.

No problem 😸 . You should ping the repository's psc's; they're the ones who maintain the whole ecosystem.

@SirPyTech
Copy link
Author

@SirPyTech We don't review things from older versions. Sorry for the inconvenience. Next time, please don't ping two people from the same company. Thanks.

Thanks for the feedback anyway 🤗 Sorry for the noise, as you know it's hard to get reviews in the OCA so I usually ping whoever might be interested.

No problem 😸 . You should ping the repository's psc's; they're the ones who maintain the whole ecosystem.

I usually bother the PSC only when the PR has enough reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants