-
Notifications
You must be signed in to change notification settings - Fork 20
Bots can trade/donate their primary weapon with their commander #1629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Testing ideas: Remember to enable the bot command feature (this is an FCVAR_ARCHIVE ConVar, so you only need to do this once) To trigger the core behavior, collect some followers using the +use button, then drop your primary, and then look at one of your followers to request their primary: bot-cmd-trade-weapons.mp4Prior to this PR, because the bot command behavior was transitioned from neo_bot_tactical_monitor, any other tactical monitor behaviors were actually suspended indefinitely in favor of the bot command behavior. The fix this PR introduces was to move the bot command behavior transition to the Scenario Monitor, which has the following test implications:
bot-cmd-grenade-avoidance-sanity-check.mp4
bot-cmd-grenade-avoidance-paused-enemies.mp4 |
| { | ||
| if (me->m_hLeadingPlayer.Get() || me->m_hCommandingPlayer.Get()) | ||
| { | ||
| return SuspendFor(new CNEOBotCommandFollow, "Following commander"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It turns out that launching into the bot commander following behavior was blocking other tactical monitor behaviors, so I moved this behavior launch point into neo_bot_scenario_monitor.
| { | ||
| if (me->m_hLeadingPlayer.Get() || me->m_hCommandingPlayer.Get()) | ||
| { | ||
| return SuspendFor(new CNEOBotCommandFollow, "Following commander"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved from neo_bot_tactical_monitor, to unblock other tactical monitor behaviors.
234d52c to
1f608d0
Compare
Description
Toolchain