Reduce team allocation for path reservation #1625
Open
+42
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
AdamTadeusz
previously approved these changes
Jan 23, 2026
Rainyan
previously approved these changes
Jan 24, 2026
This comment was marked as resolved.
This comment was marked as resolved.
Rainyan
dismissed
their stale review
GitHub requires me to write something deep and insightful in this field.
sunzenshen
commented
Jan 24, 2026
| if ( neo_bot_path_friendly_reservation_enable.GetBool() | ||
| && !m_bIgnoreReservations | ||
| && (m_routeType != FASTEST_ROUTE) ) | ||
| if ( !m_bIgnoreReservations && (m_routeType != FASTEST_ROUTE) ) |
Contributor
Author
There was a problem hiding this comment.
Realized that m_bIgnoreReservations was already set based on neo_bot_path_friendly_reservation_enable in the constructor, so there's no need to check the latter again.
Rainyan
requested changes
Jan 27, 2026
Also rename ConVar enabling the path reservation system to be more generic
sunzenshen
force-pushed
the
path-reservation-team-arrays-optimization
branch
from
27a9986 to
69b3b2d
Compare
Rainyan
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Also rename ConVar enabling the path reservation system to be more general
Toolchain
Linked Issues