Claude/fix local environment s ey3k

[Underdome134]

Summary

Related Issue

Changes

Type of Change

• Code change for a new feature, bug fix, or refactor.
• Code change with doc updates.
• Doc only. Prose changes without code sample modifications.
• Doc only. Includes code sample changes.

Testing

• make check passes.
• npm test passes.
• make docs builds without warnings. (for doc-only changes)

Checklist

General

• I have read and followed the contributing guide.
• I have read and followed the style guide. (for doc-only changes)

Code Changes

• make format applied (TypeScript and Python).
• Tests added or updated for new or changed behavior.
• No secrets, API keys, or credentials committed.
• Doc pages updated for any user-facing behavior changes (new commands, changed defaults, new features, bug fixes that contradict existing docs).

Doc Changes

• Follows the style guide. Try running the update-docs agent skill to draft changes while complying with the style guide. For example, prompt your agent with "/update-docs catch up the docs for the new changes I made in this PR."
• New pages include SPDX license header and frontmatter, if creating a new page.
• Cross-references and links verified.

Summary by CodeRabbit

• New Features

  • Added detection and support for VMware virtual GPU on Linux systems
  • Added appropriate handling for VMware virtual GPU during system configuration with cloud-inference fallback messaging

• Bug Fixes

  • Modified installation script command invocation for OpenClaw preparation and npm build dependencies

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes add VMware SVGA virtual GPU detection for Linux environments and update related onboarding logic to handle this GPU type, while also modifying shell invocation flags in installation scripts from login mode to non-login mode execution.

Changes

Cohort / File(s)	Summary
VMware GPU Detection bin/lib/nim.js, bin/lib/onboard.js	Added Linux-specific VMware SVGA GPU detection via lspci command with fallback naming and null memory values; updated onboarding preflight logic to handle vmware GPU type with cloud-inference fallback messaging.
Installation Script Updates install.sh	Replaced bash -lc with bash -c flags for executing pre_extract_openclaw and npm build steps across local package and GitHub source installation paths.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 Hoppity hop, the VMware appears!
With lspci magic, we conquer fears,
Virtual GPUs, detected with care,
Bash scripts streamlined, light as air,
The paths are now clear, for all to proceed!

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The pull request title 'Claude/fix local environment s ey3k' is vague and does not clearly convey the actual changes made (VMware GPU detection and bash shell invocation fixes).	Revise the title to be more descriptive and specific, such as 'Add VMware GPU detection and fix bash shell invocation in installation' or similar to clearly indicate the main changes.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@bin/lib/nim.js`:
- Around line 80-87: The VMware GPU stub currently returns a non-null object
which makes downstream checks like gpuEnabled: !!gpu evaluate true; change the
behavior so non-NIM VMware/cloud setups don't produce a truthy gpu object—either
return null for the gpu value when nimCapable is false or update the gpuEnabled
computation to use gpu.nimCapable (e.g., compute gpuEnabled = !!gpu &&
!!gpu.nimCapable). Locate the return in bin/lib/nim.js that creates the VMware
object (the block returning type: "vmware", nimCapable: false) and implement one
of these fixes so gpuEnabled is derived from gpu.nimCapable rather than the
presence of the object.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4adb4ca1-7d6b-4ae1-afaa-250d04922bf9

📥 Commits

Reviewing files that changed from the base of the PR and between 5eb4b71 and fdf836b.

📒 Files selected for processing (3)

• bin/lib/nim.js
• bin/lib/onboard.js
• install.sh

[Underdome134]

Please reciprocate

[wscurran]

Please update this PR with a summary, thanks!