Conversation
| @@ -0,0 +1,140 @@ | |||
|
|
|||
There was a problem hiding this comment.
If you use the .yaml format (see e.g. https://github.com/NNPDF/pinecards/pull/190/changes#diff-bd782d08506c840a9b5727f438734a2fbdbf1b26fcd2cad6755d9a9e82719e1c) it'd be easier for the future to blanket-change theory parameters.
Also, could you add the levels you ran at the bottom? It was only NLO and NNLO to get NNLO NLO-in-pt results right? (or maybe was something different... I know you told me but I already forgot :__ I need this kind of extra info because I'm old and don't get enough sleep 😿 )
There was a problem hiding this comment.
Also, don´t be like me and add the metadata.txt so that we can merge.
There was a problem hiding this comment.
Before we merge, I still need to take care of the first comment here
CMS_Z0_13TEV_A4/CMS_Z0_13TEV_A4.yaml
Outdated
| histograms: | ||
| - name: mll_bin1_proj | ||
| observable: mll | ||
| fac: proj_A4 # TODO: implement in the parser |
There was a problem hiding this comment.
This is a new option that we needed for A4, but is not yet supported by pinefarm. Let's take care of that in a dedicated PR.
There was a problem hiding this comment.
It should be ok already? https://github.com/NNPDF/pinefarm/blob/a20980b609cbba74e4c7dad36155a42423fb010d/src/pinefarm/external/nnlojet/runcardgen.py#L58
Or is it because at the moment it only accept numbers (why the hell did I write int there, it should at least be a float... luckily the fortran runcard doesn't know the difference)?
Anyway, I think just changing that to accept strings if it doesn't already should be ok. It doesn't do anything with the factor.
2 participants
NNLOJET runcards and postrun script accompanying NNPDF/nnpdf#2352