Remote input #1
Open
Remote input #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In the event_manager.py file in line 6 there is non-python code, which causes some trouble...
|
Owner
Author
Yes, that's an oversight. Only python>=3.9 correctly parses (i.e. ignores) type annotations. I'm still debating whether to deprecate py3.8 support and add type annotations to all files or ditch type annotations entirely. |
Owner
Author
|
In the meantime, upgrading to py>=3.9 should enable you to use remote input. |
|
Well, I didn't know that. I just removed that line (made it a comment) and everything worked fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to stream keyboard inputs from the lighthouse server.
Breaks the callback interface by adding a parameter
events.