-
Notifications
You must be signed in to change notification settings - Fork 128
update configs #706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update configs #706
Conversation
Summary of ChangesHello @gushiqiao, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on updating and standardizing image resizing configurations across various files. It transitions from a simple boolean flag for auto-resizing to a more explicit Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the resize configuration by replacing the _auto_resize key with resize_mode. The changes in the JSON configuration files are consistent with this refactoring. However, I've identified a potential issue in app/gradio_demo.py and app/gradio_demo_zh.py where this change alters the behavior for wan2.1 and wan2.2 models by enabling adaptive resizing for them, which was not the case before. My review includes suggestions to correct this to maintain the original behavior. Please see the detailed comments.
|
|
||
| # Set zero_cond_t to true (2511 feature) | ||
| qwen_image_config["zero_cond_t"] = True | ||
| qwen_image_config["_auto_resize"] = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This refactoring from _auto_resize to resize_mode has an unintended side effect. The new resize_mode is now hardcoded to "adaptive" for all model types in config_graio (line 1645), whereas _auto_resize was previously only enabled for qwen_image models. This changes the resizing behavior for wan2.1 and wan2.2 models in the Gradio demo.
To maintain the original behavior, resize_mode should only be set for qwen_image models. I recommend moving the resize_mode setting from config_graio into this qwen_image_config block.
You can replace the removed line with the new config key, and then remove the hardcoded resize_mode from config_graio.
| qwen_image_config["_auto_resize"] = True | |
| qwen_image_config["resize_mode"] = "adaptive" |
|
|
||
| # zero_cond_t 设置为 true(2511 的特性) | ||
| qwen_image_config["zero_cond_t"] = True | ||
| qwen_image_config["_auto_resize"] = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This refactoring from _auto_resize to resize_mode has an unintended side effect. The new resize_mode is now hardcoded to "adaptive" for all model types in config_graio (line 1645), whereas _auto_resize was previously only enabled for qwen_image models. This changes the resizing behavior for wan2.1 and wan2.2 models in the Gradio demo.
To maintain the original behavior, resize_mode should only be set for qwen_image models. I recommend moving the resize_mode setting from config_graio into this qwen_image_config block.
You can replace the removed line with the new config key, and then remove the hardcoded resize_mode from config_graio.
| qwen_image_config["_auto_resize"] = True | |
| qwen_image_config["resize_mode"] = "adaptive" |
No description provided.