Open
Conversation
# Conflicts: # simpeg_drivers-assets/uijson/direct_current_2d_forward.ui.json # simpeg_drivers-assets/uijson/direct_current_2d_inversion.ui.json # simpeg_drivers-assets/uijson/direct_current_batch2d_inversion.ui.json # simpeg_drivers-assets/uijson/induced_polarization_2d_forward.ui.json # simpeg_drivers-assets/uijson/induced_polarization_2d_inversion.ui.json # simpeg_drivers-assets/uijson/induced_polarization_batch2d_inversion.ui.json
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #358 +/- ##
===========================================
- Coverage 91.27% 90.86% -0.42%
===========================================
Files 120 112 -8
Lines 6602 6305 -297
Branches 799 775 -24
===========================================
- Hits 6026 5729 -297
- Misses 381 396 +15
+ Partials 195 180 -15
🚀 New features to boost your workflow:
|
benk-mira
reviewed
Mar 11, 2026
Contributor
benk-mira
left a comment
benk-mira
left a comment
There was a problem hiding this comment.
Looks good, nice use of utilities for separation of concerns and documenting the drape model handling! Couple suggestions
| @classmethod | ||
| def deprecated_pseudo(cls, data: dict): | ||
| if "pseudo 3d" in data.get("inversion_type", ""): | ||
| logger.warning( |
Contributor
There was a problem hiding this comment.
Use DeprecationWarning instead, something like:
Collaborator
Author
There was a problem hiding this comment.
Unfortunetly that's no longer supported.
https://docs.python.org/3/library/logging.html#logging.Logger.warning
| actives = prisms[:, -1] != 1 | ||
|
|
||
| nu_layers = np.unique(prisms[:, -1]) | ||
| nu_layers = np.unique(prisms[actives, -1]) |
Contributor
There was a problem hiding this comment.
I think I saw the same operation earlier.. pull out as a utility?
Collaborator
Author
There was a problem hiding this comment.
Here I need to logic mask, the other the reduced prisms. I really want to avoid maintaining single line functions
Co-authored-by: benk-mira <81254271+benk-mira@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.