Dispatch node profile at runtime with hint from file system #18263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
!ci-build-me |
Base automatically changed from
lyh/node-config-first-class-module
to
compatible
December 16, 2025 06:07
glyh
force-pushed
the
lyh/do-not-polyfill-a-default-dune-profile
branch
from
54be14b to
d230f14
Compare
glyh
changed the base branch from
compatible
to
lyh/simplify-unit-test-pipeline
glyh
force-pushed
the
lyh/simplify-unit-test-pipeline
branch
from
ab53e04 to
edc588e
Compare
glyh
force-pushed
the
lyh/do-not-polyfill-a-default-dune-profile
branch
from
d230f14 to
c03f3fb
Compare
Member
Author
|
!ci-build-me |
glyh
force-pushed
the
lyh/do-not-polyfill-a-default-dune-profile
branch
from
c03f3fb to
083ddb0
Compare
Member
Author
|
!ci-build-me |
glyh
force-pushed
the
lyh/do-not-polyfill-a-default-dune-profile
branch
from
083ddb0 to
cca751f
Compare
glyh
changed the title
Member
Author
|
!ci-build-me |
glyh
commented
Dec 16, 2025
| mkdir = name: | ||
| runCommand "mkdir-${name}" { } "mkdir -p $out${lib.escapeShellArg name}"; | ||
|
|
||
| mina-build-config = stdenv.mkDerivation { |
Member
Author
There was a problem hiding this comment.
Please refer to 1a46576, here is a revert of that with some tweak.
glyh
commented
Dec 16, 2025
| "${BUILDDIR}/usr/local/bin/mina" | ||
|
|
||
| # Store node config hint (based on $2) | ||
| mkdir -p "${BUILDDIR}/etc/coda/build_config" |
Member
Author
There was a problem hiding this comment.
Please refer to 1a46576, here is a revert of that with some tweak.
glyh
force-pushed
the
lyh/do-not-polyfill-a-default-dune-profile
branch
2 times, most recently
from
b1370b0 to
58585e3
Compare
Base automatically changed from
lyh/simplify-unit-test-pipeline
to
compatible
December 16, 2025 13:03
glyh
force-pushed
the
lyh/do-not-polyfill-a-default-dune-profile
branch
from
a0eb74b to
c18211d
Compare
glyh
force-pushed
the
lyh/do-not-polyfill-a-default-dune-profile
branch
from
c18211d to
00f2252
Compare
glyh
changed the title
Member
Author
|
This actually deserves a changelog. |
glyh
force-pushed
the
lyh/do-not-polyfill-a-default-dune-profile
branch
2 times, most recently
from
0af5339 to
0ae476e
Compare
Member
Author
|
!ci-nightly-me |
Member
Author
glyh
force-pushed
the
lyh/do-not-polyfill-a-default-dune-profile
branch
from
0ae476e to
b4c9cd1
Compare
Member
Author
|
!ci-build-me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up of the node config refactor.
I checked compile time code generation, it seems only GraphQL schema are used. However, they should be consistent across node config. ( This is my assumption, will run nightly to test this out)