Conversation
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
Runic
[Runic] reported by reviewdog 🐶
HyperdimensionalComputing.jl/src/types.jl
Line 288 in f173024
[Runic] reported by reviewdog 🐶
HyperdimensionalComputing.jl/src/types.jl
Line 329 in f173024
[Runic] reported by reviewdog 🐶
HyperdimensionalComputing.jl/src/types.jl
Line 334 in f173024
[Runic] reported by reviewdog 🐶
HyperdimensionalComputing.jl/src/types.jl
Line 348 in f173024
| get_vector(v::AbstractVector) = v | ||
| get_vector(hv::AbstractHV) = hv.v |
There was a problem hiding this comment.
I would change this to Base.collect, which is the intended function to use to get values from a structure.
| 10-element Vector{Float64} filled with 0.5s | ||
| ``` | ||
| """ | ||
| empty_vector(hv::AbstractHV) = zero(hv.v) |
There was a problem hiding this comment.
I would move this to Base.zero since it's more idiomatic
|
The docstrings look good. Only comment would be:
|
Documenting all the types.