feat: Attach metadata when submitting a revocation to the permission provider snap

[V00D00-child]

Explanation

This PR extends the GatorPermissionsController to allow attaching metadata when submitting a revocation to the permission provider snap. Metadata includes:

• The transaction hash
• The block timestamp

References

Requires(gator snap): feat: Store metadata when revoking a permission
Required by(MM client): chore: Bump @metamask/gator-permissions-controller to 0.9.0

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've communicated my changes to consumers by updating changelogs for packages I've changed
• I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

---

Note

Introduces metadata propagation when submitting revocations and updates types accordingly.

• BREAKING: RevocationParams now requires revocationMetadata; submitRevocation and submitDirectRevocation forward it to the snap
• On confirmed transactions, parse the transaction hash and attach it to revocationMetadata.txHash (logs if missing)
• Adds and exports RevocationMetadata type; updates imports/exports in index.ts and controller
• Extends tests to include revocationMetadata, verify params sent to permissionsProvider_submitRevocation, and confirm permissions refresh after revocation

^{Written by Cursor Bugbot for commit 50338af. This will update automatically on new commits. Configure here.}

[jeffsmale90]

Should we also add revocationMetadata to StoredGatorPermission (and as per my comments on the related PR, perhaps remove the isRevoked flag?

This would probably require some changes to how we load the permission from storage also, but IMO worthwhile,

[jeffsmale90]

Looks good to me!

One nit that I'm not especially concerned about, but might be a nice tidy up.

I am keen to understand the behaviour regarding failed transactions - we definitely don't want to be marking a permission as revoked if the transaction has failed.

[jeffsmale90]

not strictly related to this PR - but do we need to check transactionMeta.status here?

When a transaction is confirmed, do we explicitly guard against failed transactions?

[jeffsmale90]

nit: you could simplify this - moving the assignment out of the else block, and creating the revocationMetadata in a single statement:

Suggested change

	const revocationMetadata: RevocationMetadata = {};
	const { hash } = transactionMeta;
	if (hash === undefined) {
	controllerLog(
	'Failed to attach transaction hash after revocation transaction confirmed',
	{
	txId,
	permissionContext,
	error: new Error(
	'Confirmed transaction is missing transaction hash',
	),
	},
	);
	} else {
	revocationMetadata.txHash = hash as Hex;
	}
	const { hash } = transactionMeta;
	const revocationMetadata: RevocationMetadata = {
	txHash: hash as Hex | undefined,
	};
	if (hash === undefined) {
	controllerLog(
	'Failed to attach transaction hash after revocation transaction confirmed',
	{
	txId,
	permissionContext,
	error: new Error(
	'Confirmed transaction is missing transaction hash',
	),
	},
	);
	}