fix: downgrade AuthConfig partial-init log from WARNING to INFO #1052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AuthConfig.validate_partial_initialization() logs a WARNING on every startup when some components (openai, graph_db) are not configured. This is noisy because partial configuration is a valid and common state — the individual from_local_env() methods already log appropriate warnings for actual initialization failures. Change the partial-init log to INFO level; keep WARNING only for the edge case where ALL components are None. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
AuthConfig.validate_partial_initialization()logs aWARNINGon every startup when some auth components (openai, graph_db, rabbitmq) are not configured:This is noisy because partial configuration is intentional and common — most deployments only configure the components they need. The individual
from_local_env()methods already log appropriate per-component messages (INFO for skipped, WARNING for actual failures).Fix
WARNINGtoINFO(with clearer wording: "not configured" instead of "Failed to initialize")WARNINGonly for the edge case where all components are None (likely a real misconfiguration)Test plan