-
Notifications
You must be signed in to change notification settings - Fork 0
Release/v4.118.0 #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -18,8 +18,8 @@ export default { | |||||||||||||||||||||
| description: "Rust-compatible regular expression pattern to match", | ||||||||||||||||||||||
| }, | ||||||||||||||||||||||
| file_pattern: { | ||||||||||||||||||||||
| type: ["string", "null"], | ||||||||||||||||||||||
| description: "Optional string glob to limit which files are searched (e.g., '*.ts')", | ||||||||||||||||||||||
| type: ["string"], | ||||||||||||||||||||||
| description: "String glob to limit which files are searched (e.g., '*.ts')", | ||||||||||||||||||||||
| }, | ||||||||||||||||||||||
|
Comment on lines
20
to
23
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 Type Safety Issue: The Fix: Either revert to string type or update the description and validation to handle array of patterns. Impact: Prevents runtime errors when tools pass string patterns instead of arrays.
Suggested change
|
||||||||||||||||||||||
| }, | ||||||||||||||||||||||
| required: ["path", "regex", "file_pattern"], | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Type Safety
Issue: The
file_patternparameter type was changed to an array["string"], but the description and usage pattern indicate it should be a single string. This is a breaking change that could cause runtime errors.Fix: Revert the type back to
"string"to match the description and expected usage.Impact: Prevents API compatibility issues and maintains consistent tool behavior.