fix: replace require() with dependency injection for ESM compatibility#2
Open
vdg wants to merge 1 commit intoMapaor:mainfrom
Open
fix: replace require() with dependency injection for ESM compatibility#2vdg wants to merge 1 commit intoMapaor:mainfrom
vdg wants to merge 1 commit intoMapaor:mainfrom
Conversation
The footnote rendering code used require() to avoid circular imports, but require() is not available in strict ESM environments (Bun, Deno, Node.js with type: module in strict mode). This change: - Adds BlockRenderer type to types.ts - Adds optional renderBlock to RenderContext - Injects renderBlock via context from markdown2typst.ts - Uses context.renderBlock in inline-renderer.ts Maintains the same circular import avoidance while being fully ESM-compatible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1
Summary
Fixes the
require()usage ininline-renderer.tsthat breaks in strict ESM environments (Bun, Deno, Node.js with experimental VM modules).Problem
The footnote rendering code used
require()to lazily importrenderBlockand avoid circular dependencies at module load time. This fails in strict ESM environments whererequire()is not available.Solution
Use dependency injection instead:
BlockRenderertype totypes.tsrenderBlocktoRenderContextrenderBlockvia context frommarkdown2typst.tscontext.renderBlockininline-renderer.tsTesting
Breaking Changes
None. The public API is unchanged.