feat: enhance login tracking and logout functionality #661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added session storage flag to track local login success, ensuring OAuth flows do not double track login events. - Implemented tracking for logout events in both UserDropdown and AppSidebar components, resetting PostHog identity accordingly. - Minor formatting adjustments in GoogleLoginButton and footer-new components for consistency.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![recurseml[bot]](https://avatars.githubusercontent.com/in/1054195?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by RecurseML
🔍 Review performed on ae1c3f9..70890bd
✨ No bugs found, your code is sparkling clean
✅ Files analyzed, no issues (8)
• surfsense_web/app/(home)/login/GoogleLoginButton.tsx
• surfsense_web/app/(home)/login/LocalLoginForm.tsx
• surfsense_web/components/TokenHandler.tsx
• surfsense_web/components/UserDropdown.tsx
• surfsense_web/components/homepage/footer-new.tsx
• surfsense_web/components/providers/PostHogIdentify.tsx
• surfsense_web/components/providers/PostHogProvider.tsx
• surfsense_web/components/sidebar/app-sidebar.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
FIX #
Screenshots
API Changes
Change Type
Testing Performed
Checklist
High-level PR Summary
This PR enhances user analytics by integrating PostHog tracking for login and logout events. It introduces a new
PostHogIdentifycomponent that automatically identifies users when logged in and resets identity on logout. The implementation tracks both local and OAuth (Google) login successes usingsessionStorageto prevent duplicate tracking, and adds logout tracking with identity reset in multiple logout locations. Minor formatting cleanup is also included.⏱️ Estimated Review Time: 5-15 minutes
💡 Review Order Suggestion
surfsense_web/lib/posthog/events.tssurfsense_web/components/providers/PostHogIdentify.tsxsurfsense_web/components/providers/PostHogProvider.tsxsurfsense_web/app/(home)/login/LocalLoginForm.tsxsurfsense_web/components/TokenHandler.tsxsurfsense_web/components/UserDropdown.tsxsurfsense_web/components/sidebar/app-sidebar.tsxsurfsense_web/app/(home)/login/GoogleLoginButton.tsxsurfsense_web/components/homepage/footer-new.tsxsurfsense_web/components/homepage/footer-new.tsx