try: oauth_errors #659
Merged
try: oauth_errors #659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a new endpoint `/auth/google/authorize-redirect` to handle OAuth authorization via server-side redirect, addressing CSRF cookie issues in Firefox/Safari. - Updated the `GoogleLoginButton` component to use the new redirect endpoint instead of the previous JSON-based authorization method. - Enhanced CSRF cookie handling by explicitly setting the cookie domain and ensuring compatibility with cross-origin requests.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![recurseml[bot]](https://avatars.githubusercontent.com/in/1054195?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by RecurseML
🔍 Review performed on a64ab89..458c152
✨ No bugs found, your code is sparkling clean
✅ Files analyzed, no issues (1)
• surfsense_web/app/(home)/login/GoogleLoginButton.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please work
Description
Motivation and Context
FIX #
Screenshots
API Changes
Change Type
Testing Performed
Checklist
High-level PR Summary
This PR fixes Google OAuth authentication issues in Firefox and Safari browsers by implementing a redirect-based authorization flow. The changes address cross-site cookie problems where CSRF tokens set via cross-origin fetch requests weren't being sent on subsequent redirects. The frontend now uses a new
/auth/google/authorize-redirectendpoint that performs server-side redirection to Google OAuth, and the backend has been updated to properly configure CSRF cookies with appropriate domain settings and a new redirect endpoint that sets cookies in a same-site context.⏱️ Estimated Review Time: 30-90 minutes
💡 Review Order Suggestion
surfsense_web/app/(home)/login/GoogleLoginButton.tsxsurfsense_backend/app/app.py