Better handling for an empty UnreferencedSampleFiles table #7414
Open
labkey-susanh wants to merge 1 commit intorelease25.11-SNAPSHOTfrom
Open
Better handling for an empty UnreferencedSampleFiles table #7414labkey-susanh wants to merge 1 commit intorelease25.11-SNAPSHOTfrom
labkey-susanh wants to merge 1 commit intorelease25.11-SNAPSHOTfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
It is better to return a query that produces an empty table than no query at all. I'm not exactly sure when this scenario can happen in the real world, but we've seen some folder import and export tests fail on TeamCity with a blank query
Related Pull Requests
Changes
ExpUnreferencedSampleFilesTableImplwith a better response when things are empty or missing.Tasks 📍