GitHub Issue 827: Cannot aliquot samples using lineage search naming pattern#7399
Merged
GitHub Issue 827: Cannot aliquot samples using lineage search naming pattern#7399
Conversation
…mma in the name AND the aliquot naming pattern references ancestor lineage
labkey-susanh
approved these changes
Feb 13, 2026
| if (StringUtils.isEmpty((valueStr).trim())) | ||
| return Stream.empty(); | ||
|
|
||
| // GitHub Issue 827: Cannot aliquot samples where parent sample has a comma in the name AND the aliquot naming pattern references ancestor lineage |
Contributor
There was a problem hiding this comment.
Good to have the GitHub Issue reference here, but I think it would be better to explain in the text why there is special handling for ALIQUOTED_FROM here (you can get it from the PR rationale, but it takes an extra hop).
Contributor
Author
There was a problem hiding this comment.
Good reminder. I'll add the explanation in my other branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Aliquot parent can be used to lookup ancestors with lineage search syntax (~DataInputs/~MaterialInputs). If a aliquot parent name is with,comma, it would come in as "with,comma", but then processed to with,comma so the correct value is used to generate name that references the aliquot parent (Issue 45563). Because the quotes are already stripped, aliquotParent value should not go through ExperimentService.getParentValues again, which assumes TSV encoded string. This PR short circuit aliquot parent processing in parentNames util.
Related Pull Requests
Changes