Fix formatting in Ed25519 key serialization#485
Merged
Keats merged 1 commit intoKeats:masterfrom Feb 22, 2026
Merged
Conversation
In the thumbprint() function, the serialized format of the Ed25519 curve is missing double quotes around "crv", which would likely affect interoperability between other implementations. Fixes Keats#484
Owner
|
Thanks! |
peterpeterparker
added a commit
to peterpeterparker/jsonwebtoken-ic
that referenced
this pull request
Mar 17, 2026
* Expose cryptography backends via CryptoProvider (Keats#452) * Bump action number in CI * Bump some dep * Use try_sign to avoid panics (Keats#479) Closes Keats#473 * fix: bump minimal version requirements (Keats#481) Before these changes this fails: ``` cargo minimal-versions check --no-default-features --features aws_lc_rs ``` * Fix type confusion * Fix formatting in Ed25519 key serialization (Keats#485) In the thumbprint() function, the serialized format of the Ed25519 curve is missing double quotes around "crv", which would likely affect interoperability between other implementations. Fixes Keats#484 * feat: redo * chore: merge main * docs: redo * chore: set version --------- Co-authored-by: arckoor <33837362+arckoor@users.noreply.github.com> Co-authored-by: Vincent Prouillet <github@vincentprouillet.com> Co-authored-by: Vincent Prouillet <balthek@gmail.com> Co-authored-by: Carlos O'Ryan <coryan@google.com> Co-authored-by: Michael Scovetta <michael.scovetta@gmail.com>
peterpeterparker
added a commit
to peterpeterparker/jsonwebtoken-ic
that referenced
this pull request
Mar 17, 2026
* feat: use ic-sdk instead of js-sys (#3) * feat: update toml for publishing fork (#4) * docs: update readme introduction for publishing fork (#5) * feat: alias compiled library with original name for usage (#6) * chore: make rust_crypto the default feature for publishing (#7) * build: bump ic_cdk to v0.19.0 (#8) * chore: update version for release * Rebase upstream sync and integrate v10.3.0 (#9) * Expose cryptography backends via CryptoProvider (Keats#452) * Bump action number in CI * Bump some dep * Use try_sign to avoid panics (Keats#479) Closes Keats#473 * fix: bump minimal version requirements (Keats#481) Before these changes this fails: ``` cargo minimal-versions check --no-default-features --features aws_lc_rs ``` * Fix type confusion * Fix formatting in Ed25519 key serialization (Keats#485) In the thumbprint() function, the serialized format of the Ed25519 curve is missing double quotes around "crv", which would likely affect interoperability between other implementations. Fixes Keats#484 * feat: redo * chore: merge main * docs: redo * chore: set version --------- Co-authored-by: arckoor <33837362+arckoor@users.noreply.github.com> Co-authored-by: Vincent Prouillet <github@vincentprouillet.com> Co-authored-by: Vincent Prouillet <balthek@gmail.com> Co-authored-by: Carlos O'Ryan <coryan@google.com> Co-authored-by: Michael Scovetta <michael.scovetta@gmail.com> * build: bump rust version in ci for ic_cdk timer * chore: merge main --------- Co-authored-by: arckoor <33837362+arckoor@users.noreply.github.com> Co-authored-by: Vincent Prouillet <github@vincentprouillet.com> Co-authored-by: Vincent Prouillet <balthek@gmail.com> Co-authored-by: Carlos O'Ryan <coryan@google.com> Co-authored-by: Michael Scovetta <michael.scovetta@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the thumbprint() function, the serialized format of the Ed25519 curve is missing double quotes around "crv", which would likely affect interoperability between other implementations.
Fixes #484