Skip to content

Use try_sign to avoid panics#479

Merged
Keats merged 1 commit intomasterfrom
try-sign
Jan 27, 2026
Merged

Use try_sign to avoid panics#479
Keats merged 1 commit intomasterfrom
try-sign

Conversation

@Keats
Copy link
Owner

@Keats Keats commented Jan 12, 2026

Closes #473

@Keats Keats force-pushed the try-sign branch 2 times, most recently from be7ad66 to 99a2f35 Compare January 27, 2026 09:46
@Keats Keats merged commit 50d15e0 into master Jan 27, 2026
10 checks passed
@Keats Keats deleted the try-sign branch January 27, 2026 09:49
cav-chrisftw pushed a commit to cav-chrisftw/jsonwebtoken that referenced this pull request Feb 12, 2026
peterpeterparker added a commit to peterpeterparker/jsonwebtoken-ic that referenced this pull request Mar 17, 2026
* Expose cryptography backends via CryptoProvider (Keats#452)

* Bump action number in CI

* Bump some dep

* Use try_sign to avoid panics (Keats#479)

Closes Keats#473

* fix: bump minimal version requirements (Keats#481)

Before these changes this fails:

```
cargo minimal-versions check --no-default-features --features aws_lc_rs
```

* Fix type confusion

* Fix formatting in Ed25519 key serialization (Keats#485)

In the thumbprint() function, the serialized format of the Ed25519 curve is missing double quotes around "crv", which would likely affect interoperability between other implementations.

Fixes Keats#484

* feat: redo

* chore: merge main

* docs: redo

* chore: set version

---------

Co-authored-by: arckoor <33837362+arckoor@users.noreply.github.com>
Co-authored-by: Vincent Prouillet <github@vincentprouillet.com>
Co-authored-by: Vincent Prouillet <balthek@gmail.com>
Co-authored-by: Carlos O'Ryan <coryan@google.com>
Co-authored-by: Michael Scovetta <michael.scovetta@gmail.com>
peterpeterparker added a commit to peterpeterparker/jsonwebtoken-ic that referenced this pull request Mar 17, 2026
* feat: use ic-sdk instead of js-sys (#3)

* feat: update toml for publishing fork (#4)

* docs: update readme introduction for publishing fork (#5)

* feat: alias compiled library with original name for usage (#6)

* chore: make rust_crypto the default feature for publishing (#7)

* build: bump ic_cdk to v0.19.0 (#8)

* chore: update version for release

* Rebase upstream sync and integrate v10.3.0 (#9)

* Expose cryptography backends via CryptoProvider (Keats#452)

* Bump action number in CI

* Bump some dep

* Use try_sign to avoid panics (Keats#479)

Closes Keats#473

* fix: bump minimal version requirements (Keats#481)

Before these changes this fails:

```
cargo minimal-versions check --no-default-features --features aws_lc_rs
```

* Fix type confusion

* Fix formatting in Ed25519 key serialization (Keats#485)

In the thumbprint() function, the serialized format of the Ed25519 curve is missing double quotes around "crv", which would likely affect interoperability between other implementations.

Fixes Keats#484

* feat: redo

* chore: merge main

* docs: redo

* chore: set version

---------

Co-authored-by: arckoor <33837362+arckoor@users.noreply.github.com>
Co-authored-by: Vincent Prouillet <github@vincentprouillet.com>
Co-authored-by: Vincent Prouillet <balthek@gmail.com>
Co-authored-by: Carlos O'Ryan <coryan@google.com>
Co-authored-by: Michael Scovetta <michael.scovetta@gmail.com>

* build: bump rust version in ci for ic_cdk timer

* chore: merge main

---------

Co-authored-by: arckoor <33837362+arckoor@users.noreply.github.com>
Co-authored-by: Vincent Prouillet <github@vincentprouillet.com>
Co-authored-by: Vincent Prouillet <balthek@gmail.com>
Co-authored-by: Carlos O'Ryan <coryan@google.com>
Co-authored-by: Michael Scovetta <michael.scovetta@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crashing error when signing fails

1 participant