Added the ability to initialize a custom logging procedure using Driver's new_with_logging#1
Open
mlinden4 wants to merge 1 commit intoJoeOsborn:mainfrom
Open
Added the ability to initialize a custom logging procedure using Driver's new_with_logging#1mlinden4 wants to merge 1 commit intoJoeOsborn:mainfrom
mlinden4 wants to merge 1 commit intoJoeOsborn:mainfrom
Conversation
…er's new_with_logging
Owner
|
Thanks! I wonder if the dynamic dispatch could be avoided with something like: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I changed the events.rs file to add the Logger trait and added a field to Driver to remember which logger to initialize. If you don't want the field in Driver, you could move the logging initialization to Driver::new()/new_with_logging(). I also had to change a line in engine_simple because it initializes the logging outside of the Driver and had to be changed to support the default EnvLogger.