Open
Conversation
-(docs) A few minor updates to the documentation
UltCombo
requested changes
Mar 3, 2018
Member
UltCombo
left a comment
UltCombo
left a comment
There was a problem hiding this comment.
Nice work!
I've added a few comments to discuss, what do you think?
| For real world applications, you'll need to use a traspiler (at least, for a while until mid 2015). | ||
|  | ||
|
|
||
| * __NOTE__: As well pointed by Michał Gołębiowski on the comments below, browsers implementations are not fully aligned with the spec, so you may find some bugs. |
Member
There was a problem hiding this comment.
I believe this is no longer accurate, I think we can remove this note.
| There's no _hoisting_ behavior for variables declared with _let_. | ||
| With `let`, to declare variables is much more intuitive and consistent with a C-based language. | ||
| The use of `var` should be discouraged, and only _let_ var exist in use cases with legacy code. `let` and `const` will be the future of JavaScript declarations. | ||
| There's no _hoisting_ behavior for variables declared with _let_, which is another topic for later. |
Member
There was a problem hiding this comment.
We can change _let_ to let like you did in other places, also perhaps we can add a link to the TDZ post?
| [http://kangax.github.io/compat-table/es6/#](http://kangax.github.io/compat-table/es6/#). | ||
|
|
||
|  | ||
| `__let__` is currently supported by the modern browsers (even IE11) in theirs last versions and [Traceur](https://github.com/google/traceur-compiler) as well. |
Member
There was a problem hiding this comment.
Traceur seems discontinued, maybe we can replace it with Babel?
Author
|
Sorry for the delay, I've been super busy lately and just saw your notes. I will make the requested changes as soon as possible. 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-(docs) A few minor updates to the documentation.
There's much to add, I will be happy to make additional contributions if necessary.