-
Notifications
You must be signed in to change notification settings - Fork 0
Add dual-panel layout with runs table sidebar #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace floating arrow buttons with labeled edge tabs (icon + text + arrow) - Move collapsed buttons to absolute positioning at top corners - Panels hide completely when collapsed, giving full space to expanded panel - Collapse buttons show consistent styling in both states
- Wrap table in VCard with elevation to match expansion panels - Fix header heights (2.5rem) so content sections align vertically - Use underlined variant for search input to reduce header height - Standardize margin (ma-1) on both VCard and VExpansionPanels
3ae7a1e to
b3176dc
Compare
- Remove duplicate runs_table_panel_headers definition - Change flex layout to 50/50 split between table and comparison - Replace checkbox with eye/eye-off icon for comparison toggle
- Add maxWidth to table columns to prevent unbounded growth - Situation column capped at 200px with text truncation - Add info icon with hover tooltip showing full situation text - Filter controls row can now wrap when space is limited
Normalize configs via YAML round-trip before comparing to handle dict ordering/type differences from Hydra vs YAML parsing.
- state.runs now only contains runs in runs_to_compare (2-4) instead of all runs - Add incremental update methods: _add_run_to_comparison, _remove_run_from_comparison, _update_run_in_comparison, _rebuild_comparison_runs - Add run_to_table_row_direct() to create table rows without full state dict - Update all callers to use incremental methods instead of full rebuilds - Fix export fallback to use registry instead of state.runs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan