Fix duplicate-column sorting issue in Text2SQL evaluation utils#1954
Merged
elronbandel merged 2 commits intomainfrom Jan 7, 2026
Merged
Fix duplicate-column sorting issue in Text2SQL evaluation utils#1954elronbandel merged 2 commits intomainfrom
elronbandel merged 2 commits intomainfrom
Conversation
Signed-off-by: Oktie Hassanzadeh <hassanzadeh@us.ibm.com>
elronbandel
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an error under Python 3.12+ for when dataframes have duplicate column names (more likely when there are joins in the SQLs).
Replaces label-based column selection in
sort_dfwith positional selection viailoc. This prevents cases wheredf[col]resolves to a DataFrame (Python 3.12 / duplicate columns), which causedsort_valuesto raise a missingbyargument error.Thanks to @tkaple for the fix.