Make the Requested amount field accepts locale formated values#4767
Open
Make the Requested amount field accepts locale formated values#4767
Conversation
…uested amount field. Add custom prepare_value to make the widget use the locale correct decimal seperator.
Member
Author
|
I used up a lot of Claude code tokens for this 😄. So many nitty gritty details but after hours of testing I believe (hope) it's working. Really needs testing by other people, important that this does not mess up users data. If we can be sure it works I think it will be a nice ux improvement, allowing users to enter values the way they are used to and Hypha takes care of the rest. |
Member
Author
|
@bmispelon I heard you created a solution for this already. Something similar to above or did you find a cleaner fix for it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4628
Add custom
to_python()function to allow localised number inputs to Requested amount field. Add customprepare_value()to make the widget use the locale correct decimal separator.Test Steps