This repository was archived by the owner on May 22, 2020. It is now read-only.
RUN-5538 - Expose findInPage and stopFindInPage APIs#361
Closed
luiemilio wants to merge 13 commits intoHadoukenIO:developfrom
luiemilio:RUN-5538_findInPage
Closed
RUN-5538 - Expose findInPage and stopFindInPage APIs#361luiemilio wants to merge 13 commits intoHadoukenIO:developfrom luiemilio:RUN-5538_findInPage
luiemilio wants to merge 13 commits intoHadoukenIO:developfrom
luiemilio:RUN-5538_findInPage
Conversation
rdepena
suggested changes
Oct 8, 2019
openfin-github-bot
bot
added
the
auto testing started
Git
Asars used for testingTest results
|
openfin-github-bot
bot
added
auto testing done
openfin-github-bot
bot
added
auto testing started
Git
Asars used for testingTest results
|
openfin-github-bot
bot
added
auto testing done
openfin-github-bot
bot
added
auto testing started
Git
Asars used for testingTest results
|
openfin-github-bot
bot
added
auto testing done
openfin-github-bot
bot
added
auto testing started
Git
Asars used for testingTest results
|
openfin-github-bot
bot
added
auto testing done
rdepena
suggested changes
Oct 16, 2019
tutorials/Window.findInPage.md
Outdated
| @@ -0,0 +1,12 @@ | |||
| Find and highlight text on a page | |||
Member
There was a problem hiding this comment.
This tutorial is not at all descriptive of what the feature does.
Member
Author
There was a problem hiding this comment.
added better description
tutorials/Window.stopFindInPage.md
Outdated
| @@ -0,0 +1,14 @@ | |||
| Stop findInPage call with the specified action | |||
Member
There was a problem hiding this comment.
This tutorial is not at all descriptive of what the feature does.
Member
Author
There was a problem hiding this comment.
added better description
licui3936
reviewed
Oct 16, 2019
src/api/webcontents/webcontents.ts
Outdated
| } | ||
| } No newline at end of file | ||
|
|
||
| public findInPage(searchTerm: string, options?: any): Promise<number> { |
Collaborator
There was a problem hiding this comment.
The type of 'options' is FindInPageOptions ?
Member
Author
There was a problem hiding this comment.
added the type to the func
openfin-github-bot
bot
added
auto testing started
Git
Asars used for testingTest results
|
openfin-github-bot
bot
added
auto testing done
openfin-github-bot
bot
added
auto testing started
Git
Asars used for testingTest results
|
openfin-github-bot
bot
added
auto testing done
licui3936
approved these changes
Oct 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Expose Electron's Find In Page API
Core PR: HadoukenIO/core#987
Checklist
npm testpassesRelease Notes
Added API to find and highlight text on a page.
Notes: