Brussels | ITP-2025-1 | Truong Vinh Kien | Week 6 | Sprint 3 implement and rewrite tests #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 27 commits
October 15, 2025 16:11
testing for five heart, J, Q, K value of 10 default ace value
MustafaBora
reviewed
Jan 7, 2026
| // What other scenarios could you test for? | ||
|
|
||
| const zeroNumerator = isProperFraction(0, 5); | ||
| assertEquals(zeroNumerator, true); |
There was a problem hiding this comment.
Very good, covers also negatives bc you check for absolute values. So -5/2 also would give false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.