ITP-2025-1|Elena Vasileia|Week 4|Module-Structuring-and-Testing-Data/Sprint-1 #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify comments explaining variable declaration and reassignment.
Created a variable initials by calling the location of a letter in a string (in this example location is 0, the first letter)
I used the same logic as the base variable, but I calculated all the locations after the dot
Used the same logic but chose the beggining of filePath till the last slash.
Added comments explaining how this works. A dice example helped me to understand it in the first place
Switched lines to comments and explained how to do so in another comment
Changed 'const' to 'let' for the age variable to allow reassignment.
Moved the declaration of cityOfBirth before its usage in console.log.
Changed cardNumber to a string to use slice method as it is only applied to strings
Renamed variables to start with a letter not a number
Found the function calls, identified the error and fixed it, found where variables are reassigned and where they were declared and explained why we have to remove the comma from a string "10,000" before we turn it into number.
Explained everything that was asked for in comments
Added explanations for alert and prompt functions.
Clarified the explanation of the console object and its methods.
Added comments to clarify the purpose of each variable and operation in the conversion from pence to pounds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self checklist
In this PR are included all the excercises we had to do in sprint-1