Open
Conversation
… will try to install needed dependancies using a package manager
| exit 1 | ||
| fi | ||
|
|
||
| # try to install using apt-get |
| echo 'Python 3 is not installed. Please install it!' | ||
| installProg 'python3' | ||
|
|
||
| printf "\e[31mRe-run this script to try again\e[0m\n" |
Member
There was a problem hiding this comment.
This doesn't explain why a user might have to try again. I can foresee people complaining about this and making our lives very sad.
Member
There was a problem hiding this comment.
Actually, I think this line isn't reachable? installProg always exits?
| exit 1 | ||
| fi | ||
|
|
||
| isEmail=$(git config -l | grep "user\.email" | wc -l) |
| fi | ||
|
|
||
| isEmail=$(git config -l | grep "user\.email" | wc -l) | ||
| isName=$(git config -l | grep "user\.name" | wc -l) |
|
|
||
|
|
||
| if [ "${team[0]}" == "${team[1]}" ]; then | ||
| printf "\e[31mTeam members can not have the same GitHub username\e[0m\n" |
Member
There was a problem hiding this comment.
Can combine this with the other conditions below by if [ ... ] || [ ... ] || [ ... ]
| echo 'Cloned.' | ||
| echo '' | ||
|
|
||
| echo 'removing non challenge files' |
Member
There was a problem hiding this comment.
I wouldn't even echo this at the risk of confusing people. Maybe make it a call to debug if you want.
keeferrourke
approved these changes
Sep 25, 2019
Member
keeferrourke
left a comment
keeferrourke
left a comment
There was a problem hiding this comment.
Approved! Please address my comments before merge though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
will now have even more colors, will prompt for git config infos, and will try to install needed dependancies using a package manager
Note it will not actually change the directory because the script will run in a subshell but it will output a colured output telling you to change directories
Closes #7 and #6