refactor(chart): Change to sidecar pattern for multi-node deployment#5
Merged
ianchen0119 merged 5 commits intoGthulhu:mainfrom Dec 1, 2025
Merged
Conversation
Merge separate scheduler and api configurations into a unified pod structure to enable sidecar pattern deployment. This change groups both containers under a single pod configuration while maintaining granular control over individual container settings. Changes: - Introduce pod.enabled flag for unified deployment control - Restructure scheduler config as pod.scheduler with image and resources - Restructure API config as pod.api as sidecar container configuration
Merge previously separate scheduler and API DaemonSets into one, running both as containers in the same pod. This enables localhost communication and guarantees co-location on each node. Changes: - Run scheduler and API as containers in same DaemonSet pod - Share hostPID and system volumes (/proc, /sys/kernel/debug) - Simplify deployment from 2 DaemonSets to 1
Update scheduler configuration to use localhost for API communication instead of ClusterIP service. This change is required for the sidecar pattern where both containers run in the same pod and share the network namespace. Changes: - Update api.url from http://gthulhu-api:80 to http://localhost:8080 - Update template variable references to use pod configuration - Remove dependency on ClusterIP service for communication
Service is unnecessary in sidecar mode as containers communicate via localhost within the same pod. Changes: - Update condition to use service.enabled flag - Update variable references to service configuration - Remove component selector to match unified DaemonSet
Changes: - Merge 2 ClusterRoles/Bindings into 1 in rbac.yaml - Update variable references in NOTES.txt, ingress.yaml, and test files - Add service.enabled conditions for optional Service access
Andrewtangtang
changed the title
Contributor
Author
|
Hi @ianchen0119 , when you have a moment, please take a look. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Consolidate scheduler and API into single DaemonSet with sidecar pattern,
enabling localhost communication and preparing for future multi-node
Manager-Decision Maker architecture.
Changes: