Fix description truncation for emoji and wide characters#4080
Draft
thaafox wants to merge 1 commit intoGothenburgBitFactory:developfrom
Draft
Fix description truncation for emoji and wide characters#4080thaafox wants to merge 1 commit intoGothenburgBitFactory:developfrom
thaafox wants to merge 1 commit intoGothenburgBitFactory:developfrom
Conversation
The "truncated" and "truncated_count" description styles use std::string::substr() with a byte offset derived from display width, which splits multi-byte UTF-8 sequences (emoji, CJK characters) mid-character, producing garbled output. Replace with utf8_truncate_to_width() which iterates by codepoint and respects character boundaries. Fixes GothenburgBitFactory#2333
Collaborator
|
This looks like an AI-generated PR so I won't comment extensively, but please mark this as ready for review when it is ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace byte-based
substr()withutf8_truncate_to_width()in ColDescription truncated/truncated_count render styles.Fixes #2333
Depends on GothenburgBitFactory/libshared#114
Problem
Truncating descriptions containing emoji or other multi-byte UTF-8 characters produces garbled output because
substr()cuts at byte boundaries, not character boundaries. This affects all platforms.Screenshot
Changes
ColDescription.cpp: 2 lines changed —description.substr()→utf8_truncate_to_width(description, ...)Test plan
task add "📄 Emoji renders correctly"displays properly...suffix