Skip to content

Conversation

@vinnybod
Copy link
Contributor

@vinnybod vinnybod commented Jan 6, 2026

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @vinnybod, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the container-structure-test tool by introducing the ability to output test results to two distinct destinations concurrently: the standard output stream and a designated report file. This change addresses the previous limitation where specifying a report file would redirect all output and potentially alter the primary output format. By refactoring the output handling, users can now receive real-time feedback on stdout while also generating a structured JUnit XML report for integration with CI/CD systems, without conflicts in output streams or formats.

Highlights

  • Dual Output Stream: The tool can now output test results to stdout (or the primary output writer) while simultaneously writing a JUnit XML report to a specified file.
  • Decoupled Output Formats: Specifying a report file no longer forces the primary output format to JSON; stdout can maintain its original format (e.g., text).
  • Refactored Output Handling: The run and ProcessResults functions have been updated to accept and manage a separate reportOut writer for dedicated report file output.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the test output logic to allow writing test results to stdout while also generating a report file. Previously, specifying a report file would redirect all output. The changes introduce a separate writer for the report file and update the result processing logic accordingly. This is a good improvement for user experience. However, the new implementation hardcodes the report file format to JUnit XML, which is a breaking change and contradicts the CLI help text that mentions JSON support. I've left a comment with more details on this. Additionally, the PR includes a small but important fix for a buggy Fatalf call.

@vinnybod vinnybod marked this pull request as draft January 6, 2026 18:25
@vinnybod vinnybod marked this pull request as ready for review January 6, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant