Open
Conversation
…rompt Tag, Installed expo-image package
…Added countdown functionality, fixed auto height and width issue, adjusted boldness.
JasonMun7
requested changes
Jul 2, 2024
Collaborator
There was a problem hiding this comment.
Amazing work Andrew!
Thank you for creating separate components for the pomrptCardTag and the PromptCardCountdown in order to be used for the rest of the pages. My one comment on the PromptCardCountdown.tsx:
- Simplify and reduce the code by reducing the number of useEffects. I think we can keep track whether it's running without the constant so we can combine the first. and third useEffect
Great work with providing the skeleton navigation for the answer button. We'll prompt it to navigate to the upload page once we get that developed.
I'm going to go in and test the component as well. Before and after the new changes.
…che beginning functions for performance, Removed isRunning state
Member
Author
|
Pushed new commit where the useEffects were consolidated. |
JasonMun7
approved these changes
Jul 6, 2024
Collaborator
JasonMun7
left a comment
There was a problem hiding this comment.
Hey Andrew! This PromptCardCountdown looks a lot better! I'll move this into testing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finished UI Skeleton of Prompt Card
Notes:
Packages Added: