Batch load message entities in view results#229
Open
nikanderson wants to merge 1 commit intoGizra:7.x-1.xfrom
Open
Batch load message entities in view results#229nikanderson wants to merge 1 commit intoGizra:7.x-1.xfrom
nikanderson wants to merge 1 commit intoGizra:7.x-1.xfrom
Conversation
amitaibu
reviewed
Jul 10, 2018
| class message_handler_field_message_render extends views_handler_field { | ||
|
|
||
| // Message entities | ||
| var $messages = array(); |
Member
There was a problem hiding this comment.
I would avoid this $messages - as we end up caching this inside message_load and here. Instead - you can do something like:
function pre_render() {
...
+ if (empty($mids)) {
// No Message IDs.
return;
}
// Load the Messages in a single call, so they will be statically cached in the ::render function.
message_load_multiple($mids);
}Then, the render function will stay as-is, the message_load will however fetch the $message from the static cache.
amitaibu
reviewed
Jul 10, 2018
| $field_alias = $this->field_alias; | ||
|
|
||
| foreach ($values as $value) { | ||
| if (!empty($value->{$field_alias})) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
pre_rendermethod tomessage_handler_field_message_renderin order to batch-load Message entities rather than loading them one by one inrender()