Conversation
r3shabh
commented
Oct 26, 2017
Hacker New Top 10
Also changed the file name of Rolling dice.
It was just returning one value.
A statement can be printed using single quotes too. Also there were some spelling errors.
Update List of ideas.md
Contributor
divyanshu-rawat
left a comment
There was a problem hiding this comment.
I guess you have copied this script from somewhere :)
yashovardhan
reviewed
Nov 4, 2017
There was a problem hiding this comment.
I don't feel you have committed anything, and also your remote is wrongly set.
Commenting script that too copied in the description is not a way to commit and send PR.
First, learn the proper way and then try to do things rather than spamming the repository.
Person Incharge of this repository will close this PR if he feels so.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.