Skip to content

refactor(block-buffer-manager): add Historical variant to BlockState for recovered blocks #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Lchangliang wants to merge 3 commits into
base: main
Choose a base branch
from
Open

refactor(block-buffer-manager): add Historical variant to BlockState for recovered blocks #550

Lchangliang wants to merge 3 commits into from

Conversation

@Lchangliang
Copy link
Contributor

@Lchangliang Lchangliang commented Feb 3, 2026

  • Add Historical { id: BlockId } variant to BlockState enum for blocks recovered from storage that don't have actual compute_result
  • Replace fake Committed state with Historical in init() method
  • This avoids constructing dummy StateComputeResult for historical blocks
  • Update all match arms to handle the new Historical variant

@Lchangliang
refactor(block-buffer-manager): add Historical variant to BlockState …
67f0886 
…for recovered blocks

- Add Historical { id: BlockId } variant to BlockState enum for blocks
  recovered from storage that don't have actual compute_result
- Replace fake Committed state with Historical in init() method
- This avoids constructing dummy StateComputeResult for historical blocks
- Update all match arms to handle the new Historical variant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ByteYue ByteYue ByteYue approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Lchangliang @ByteYue