fix: Fix thermal conductivity #3941
Open
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkachuma
requested review from
CusiniM,
jhuang2601 and
paveltomin
as code owners
dkachuma
added
ci: run CUDA builds
paveltomin
approved these changes
Jan 22, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3941 +/- ##
===========================================
- Coverage 58.93% 58.93% -0.01%
===========================================
Files 1351 1351
Lines 112834 112835 +1
===========================================
Hits 66499 66499
- Misses 46335 46336 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jafranc
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somewhere along the line the proper resizing of the rock thermal conductivity for the volume weighted model was lost. This was resulting in a seg fault in models using this.