refactor: Enforce arrayRef regex & Handling and XML Spacing Rules #3900
+179
−85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arng40
requested review from
CusiniM,
MelReyCG,
OmarDuran,
castelletto1,
corbett5,
dkachuma,
herve-gross,
jhuang2601,
paveltomin,
rrsettgast and
wrtobin
as code owners
arng40
added
type: cleanup / refactor
arng40
changed the title
arng40
changed the title
arng40
changed the title
arng40
added
ci: run CUDA builds
herve-gross
approved these changes
Nov 24, 2025
MelReyCG
requested changes
Nov 28, 2025
Contributor
MelReyCG
left a comment
MelReyCG
left a comment
There was a problem hiding this comment.
need a few more work on unit tests
MelReyCG
requested changes
Dec 5, 2025
Comment on lines
381
to
384
| std::string groupNameComp; | ||
| std::istringstream ss( input.m_valueToTest ); | ||
| ss >> groupNameComp >> std::ws; | ||
| EXPECT_STREQ( groupNameComp.c_str(), groupName.c_str() ); |
Contributor
There was a problem hiding this comment.
Your last fix...
EXPECT_STREQ( groupName.c_str(), groupName.c_str() );
... is like a a == a check, it does not check anything.
MelReyCG
requested changes
Dec 29, 2025
Comment on lines
381
to
384
| std::string groupNameComp; | ||
| std::istringstream ss( input.m_valueToTest ); | ||
| ss >> groupNameComp >> std::ws; | ||
| EXPECT_STREQ( groupNameComp.c_str(), groupName.c_str() ); |
Contributor
There was a problem hiding this comment.
Your last fix...
EXPECT_STREQ( groupName.c_str(), groupName.c_str() );
... is like a a == a check, it does not check anything.
MelReyCG
requested changes
Dec 29, 2025
| for( GroupNameTest const & input : workingInputs ) | ||
| { | ||
| EXPECT_NO_THROW( xmlWrapper::stringToInputVariable( groupName, input.m_valueToTest, input.m_regex ) ); | ||
| EXPECT_STREQ( input.m_valueToTest.c_str(), groupName.c_str() ); |
Contributor
There was a problem hiding this comment.
Here is the place that needs to be reworked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reference an array of groups aka
groupNameRefArray, we ensure we have to writeattribute="{*}".We cannot longer write for example :
attribute="*"Also allow to have spaces spaces before and after a value in an attribute :