Implement Electron Velocity Changes#331
Implement Electron Velocity Changes#331bear-is-asleep wants to merge 90 commits intoGENIE-MC:masterfrom
Conversation
…andomizer for bohr velocity
…into brindenc Updating my branch with nu e updates
…rection randomizer for bohr model
mroda88
left a comment
There was a problem hiding this comment.
Starting to make comments. Here are a few initial
mroda88
left a comment
There was a problem hiding this comment.
Most of the changes are technical. There is one issue with the threshold though.
|
With this I had a look at the whole thing. On top of the "errors" I pointed out, I think we need a few testing macro, to verify that the events are produced in the right way. I think we just need a loop over the events that extracts
[edit] Following our conversation, you told me you have something already. Please upload it in |
…nt for neutrino direction, added validation to contrib, added invalid kinematics check
mroda88
left a comment
There was a problem hiding this comment.
We are getting there. Some changes to be made.
Let's not forget the ValidKinematic check ow that the HitPartPdg is set correctly.
We need to understand if the energy threshold is evaluated correctly. in the framework.
…d process. Updated .gitignore to remove my changes
mroda88
left a comment
There was a problem hiding this comment.
There are still problems with the handling of the threshold. As a matter of fact, we should check if IsAboveThreshold from the kinematic phase space does the right job now that we changed the interaction.
…re xsec = 0 in integration
…re xsec = 0 in integration
No description provided.