Merged
Conversation
The node update action was missing the required 'id' parameter in its definition. This fix adds the id parameter (Node UUID) as a required field to the node.yaml definition, ensuring the update action can properly identify which node to update. Ticket: GPCO-8
…nerator enum handling Make description and environment optional in project create/update since they are deprecated in the proto (removal date 2025/03/01 already passed). Fix generator bug where non-required enum params incorrectly used pointer semantics for plain proto3 enum fields. Add explicit 'optional' YAML flag for proto oneof/optional pointer fields. - Mark project description/environment as deprecated and optional - Fix generator enum pointer handling in sub_command.go - Add Optional field to Param struct in definition.go - Mark image cloud_provider_type as optional (oneof pointer field) Ticket: GPCO-8
…nt available The network create command has been disabled because the ListSubnets endpoint is missing from the gRPC API. This endpoint is required to resolve subnet IDs provided by users. The command will be re-enabled once the admin.ListSubnets endpoint becomes available in the gRPC API. Key changes: - Replaced full implementation with documentation comments - Added TODO for re-enabling once ListSubnets is available - Noted the flag name fix needed (subnet-ids vs subnets) Ticket: GPCO-8
Correct misleading flag descriptions and defaults in several commands. - Fix network-arp mac_address description from "IP address" to "MAC address" - Make node reinstall user_data optional with empty default - Remove false "(required)" from rescue mode enabled/password descriptions Ticket: GPCO-8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.