-
Notifications
You must be signed in to change notification settings - Fork 14
Add Perfetto profiling support to CI workflow #341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
greenc-FNAL
wants to merge
4
commits into
main
Choose a base branch
from
feature/perfetto-profiling
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
8805a72
Add Perfetto profiling support to CI workflow
greenc-FNAL 19c42ac
Apply suggestions from code review
greenc-FNAL f3018ad
Address Copilot review comments from #341
greenc-FNAL 62f6c6c
Document tracebox supply-chain limitation in Dockerfile
greenc-FNAL File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,6 +6,7 @@ | |
| /_deps/ | ||
| /build-*/ | ||
| /build/ | ||
| /out/ | ||
| /phlex-build/ | ||
| /phlex-src/ | ||
| CMakeFiles/ | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| # FindPerfetto.cmake | ||
| # Finds the Perfetto SDK (single-header implementation) | ||
|
|
||
| include(FindPackageHandleStandardArgs) | ||
|
|
||
| find_path( | ||
| Perfetto_INCLUDE_DIR | ||
| NAMES perfetto.h | ||
| PATHS /opt/perfetto /usr/local/include /usr/include | ||
| DOC "Perfetto SDK header location" | ||
| ) | ||
|
|
||
| find_file( | ||
| Perfetto_SOURCE | ||
| NAMES perfetto.cc | ||
| PATHS /opt/perfetto /usr/local/include /usr/include | ||
| DOC "Perfetto SDK implementation file" | ||
| ) | ||
|
|
||
| find_package_handle_standard_args(Perfetto REQUIRED_VARS Perfetto_INCLUDE_DIR Perfetto_SOURCE) | ||
|
|
||
| if(Perfetto_FOUND AND NOT TARGET Perfetto::Perfetto) | ||
| find_package(Threads REQUIRED) | ||
| add_library(Perfetto_impl STATIC "${Perfetto_SOURCE}") | ||
| target_include_directories(Perfetto_impl PUBLIC "${Perfetto_INCLUDE_DIR}") | ||
| target_compile_definitions(Perfetto_impl PUBLIC PERFETTO_ENABLE_TRACING=1) | ||
| target_link_libraries(Perfetto_impl PUBLIC Threads::Threads) | ||
| add_library(Perfetto::Perfetto ALIAS Perfetto_impl) | ||
| endif() | ||
|
|
||
| mark_as_advanced(Perfetto_INCLUDE_DIR Perfetto_SOURCE) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.