Skip to content

Conversation

@dennisklein
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jun 1, 2020

Codecov Report

Merging #3 (be3d44b) into master (54847cd) will decrease coverage by 14.59%.
The diff coverage is 46.80%.

❗ Current head be3d44b differs from pull request most recent head 00bbcc2. Consider uploading reports for the commit 00bbcc2 to get more accurate results

@@             Coverage Diff              @@
##            master       #3       +/-   ##
============================================
- Coverage   100.00%   85.40%   -14.60%     
============================================
  Files            7        8        +1     
  Lines          140      185       +45     
  Branches         6       11        +5     
============================================
+ Hits           140      158       +18     
- Misses           0       25       +25     
- Partials         0        2        +2     
Impacted Files Coverage Δ
lib/alfaci/subprocess.py 33.33% <33.33%> (ø)
lib/alfaci/repo.py 93.02% <88.88%> (-6.98%) ⬇️
lib/alfaci/__init__.py 100.00% <100.00%> (ø)
lib/alfaci/cli.py 100.00% <100.00%> (ø)

@lgtm-com
Copy link

lgtm-com bot commented Oct 7, 2021

This pull request introduces 4 alerts when merging 1307549 into 5980da9 - view on LGTM.com

new alerts:

  • 3 for Module-level cyclic import
  • 1 for Module is imported with 'import' and 'import from'

@lgtm-com
Copy link

lgtm-com bot commented Oct 7, 2021

This pull request introduces 4 alerts when merging 00bbcc2 into 5980da9 - view on LGTM.com

new alerts:

  • 3 for Module-level cyclic import
  • 1 for Module is imported with 'import' and 'import from'

Comment on lines +5 to +6
except ImportError:
import asyncio
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a

    run = None

here

and later replace

-    if sys.version_info < (3, 7, 0):
+    if run is None:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants