You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This merge request modifies ptchsize to require a command line argument for the compiler used to compile freecom. It also modifies the build.sh and build.bat scripts accordingly.
The additional heap is reduced to 6k again, as it should be sufficient?!?
I don't think making this compiler dependent is a smart idea,
each command.com needs a minimum of heap. and no compiler on this planet can know
how much is needed.
with XMS_SWAP active, that's irrelevant
without XMS_SWAP, the heap is frozen as soon as KEYB is loaded.
later commands my use more heap then is currently allocated.
command minimum heap really should be allocated through EXE header.
but anyway (I don't care much about GCC)
if (compiler != COMPILER_GCC) {
if(fseek(freecom, ival.heapPos, SEEK_SET) != 0) {
printf("Failed to seek to heap size offset in %s\n", argv[1]);
return 42;
}
assert(sizeof(tosize) == 2);
if(fwrite(&tosize, sizeof(tosize), 1, freecom) != 1) {
printf("Failed to patch heap size into FreeCOM executable.\n"
"File most probably corrupted now: %s\n", argv[1]);
return 75;
}
}
silently doing nothing when compiler is GCC isn't smart (as the last version did). please do at least
...
else
printf("while instructed to do something, I ignore you because GCC doesn't need this\n");
I don't think making this compiler dependent is a smart idea.
Me too. But I am currently not sure what the side effects of changing it are. So for the moment this is a minimal patch to make it work again, until I or someone else has the time to deal with it in the proper way. I will add the message you suggested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merge request modifies ptchsize to require a command line argument for the compiler used to compile freecom. It also modifies the build.sh and build.bat scripts accordingly.
The additional heap is reduced to 6k again, as it should be sufficient?!?
build.sh is fixed to run on MacOS.