Fix injection vulnerabilities and add protection tests#8
Merged
Conversation
Tests verify the workflow handles dangerous patterns without breaking:
- JS template literals: ${VAR}, ${process.exit(1)}
- Shell injection: $(cmd), `cmd`, $VAR
- GitHub Actions expressions: ${{ secrets.TOKEN }}
- JSON special chars: quotes, backslashes, newlines
- Other: pipes, redirects, HTML comments
Also updates malicious skill fixture to include all these patterns.
Deploying everyskill with
|
| Latest commit: |
ad130cc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fa5848bf.everyskill.pages.dev |
| Branch Preview URL: | https://fix-injection-protection.everyskill.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix JS template literal injection - AI responses containing
${VAR}patterns were being evaluated as JavaScript. Now passes responses viaprocess.envto treat them as plain strings.Add comprehensive injection protection tests:
test-shell-escaping- Verifies backticks,$(cmd),$VARdon't executetest-comment-construction- Verifies${VAR},${{ }}don't break JSUpdated malicious skill fixture with all injection patterns:
${SECRETS},${process.exit(1)}`id`,$(whoami),$HOME${{ secrets.TOKEN }}Test plan